30c56f9330
A successful (2xx) answer from Hiboutik is now the truth, even an empty list: records missing from it are deleted. The "empty list means API issue" safety nets are removed. Deletion stays safe because a failed call deletes nothing: HTTP errors throw, and the new HiboutikClient.getList (used by getAllPages and the non-paginated lists) also throws on a 2xx body that is not a list, so a malformed answer is never mistaken for an empty list. A 2xx without body is an empty list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
67 lines
2.7 KiB
TypeScript
67 lines
2.7 KiB
TypeScript
import { Injectable } from '@nestjs/common';
|
|
import { HttpService } from '@nestjs/axios';
|
|
import { ConfigService } from '@nestjs/config';
|
|
import { firstValueFrom } from 'rxjs';
|
|
|
|
/** Results per page of every paginated Hiboutik endpoint (see "Results per page" in the API docs). */
|
|
const HIBOUTIK_PAGE_SIZE = 250;
|
|
|
|
/** Low-level HTTP client for the Hiboutik REST API: base URL and Basic auth credentials come from the environment. */
|
|
@Injectable()
|
|
export class HiboutikClient {
|
|
private readonly baseUrl: string;
|
|
private readonly authHeader: string;
|
|
|
|
constructor(
|
|
private readonly httpService: HttpService,
|
|
private readonly configService: ConfigService,
|
|
) {
|
|
const username = this.configService.get<string>('HIBOUTIK_USERNAME') ?? '';
|
|
const password = this.configService.get<string>('HIBOUTIK_PASSWORD') ?? '';
|
|
this.authHeader = `Basic ${Buffer.from(`${username}:${password}`).toString('base64')}`;
|
|
this.baseUrl = this.configService.get<string>('HIBOUTIK_BASE_URL') ?? '';
|
|
}
|
|
|
|
/** GET on a Hiboutik path (relative to `HIBOUTIK_BASE_URL`), returns the response body. */
|
|
async get<T>(path: string, params?: Record<string, unknown>): Promise<T> {
|
|
const response = await firstValueFrom(
|
|
this.httpService.get<T>(`${this.baseUrl}${path}`, {
|
|
headers: { Authorization: this.authHeader },
|
|
params,
|
|
}),
|
|
);
|
|
return response.data;
|
|
}
|
|
|
|
/**
|
|
* GET on a list endpoint. HTTP errors (4xx/5xx) throw, a 2xx answer without body is an empty list, and any other
|
|
* non-list body throws: an empty list triggers deletions in the sync, so it must never be inferred from a malformed answer.
|
|
*/
|
|
async getList<T>(path: string, params?: Record<string, unknown>): Promise<T[]> {
|
|
const data = await this.get<T[] | '' | null | undefined>(path, params);
|
|
if (data === '' || data == null) return [];
|
|
if (!Array.isArray(data)) throw new Error(`Unexpected answer from Hiboutik ${path}: a list was expected`);
|
|
return data;
|
|
}
|
|
|
|
/**
|
|
* Fetches every page of a paginated endpoint (`p` param, starting at 1) and concatenates the results.
|
|
* Only for paginated endpoints: on a non-paginated one, a full first page would loop forever on the same results.
|
|
*/
|
|
async getAllPages<T>(path: string, baseParams: Record<string, unknown> = {}): Promise<T[]> {
|
|
const results: T[] = [];
|
|
let page = 1;
|
|
|
|
while (true) {
|
|
const pageData = await this.getList<T>(path, { ...baseParams, p: page });
|
|
if (pageData.length === 0) break;
|
|
results.push(...pageData);
|
|
// A page smaller than the page size is the last one: no need to request an empty page
|
|
if (pageData.length < HIBOUTIK_PAGE_SIZE) break;
|
|
page++;
|
|
}
|
|
|
|
return results;
|
|
}
|
|
}
|